linux-kernel - Re: [RFC][Resend] Make NFS-Client readahead tunable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76bd70e30809181124t78c0d574gaed5702095c02921@mail.gmail.com>
Date:	Thu, 18 Sep 2008 13:24:42 -0500
From:	"Chuck Lever" <chucklever@...il.com>
To:	"Martin Knoblauch" <knobi@...bisoft.de>
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Greg Banks" <gnb@...bourne.sgi.com>,
	"linux-nfs list" <linux-nfs@...r.kernel.org>,
	linux-kernel@...r.kernel.org,
	"Peter zijlstra" <a.p.zijlstra@...llo.nl>
Subject: Re: [RFC][Resend] Make NFS-Client readahead tunable

On Thu, Sep 18, 2008 at 6:53 AM, Martin Knoblauch <knobi@...bisoft.de> wrote:
> ----- Original Message ----
>
>> From: Andrew Morton <akpm@...ux-foundation.org>
>> To: Martin Knoblauch <knobi@...bisoft.de>
>> Cc: Greg Banks <gnb@...bourne.sgi.com>; linux-nfs list <linux-nfs@...r.kernel.org>; linux-kernel@...r.kernel.org; Peter zijlstra <a.p.zijlstra@...llo.nl>
>> Sent: Thursday, September 18, 2008 10:47:33 AM
>> Subject: Re: [RFC][Resend] Make NFS-Client readahead tunable
>>
>> On Thu, 18 Sep 2008 01:38:57 -0700 (PDT) Martin Knoblauch
>> wrote:
>>
>> > > No.  mount(8) will pass unrecognised options straight down into the
>> > > filesystem driver.
>> > >
>> >
>> >  Has that always been the case, or is it a recent change? I have to support
>> RHEL4 userland, which is not really new.
>>
>> It's been that way for ever and ever.  It's how all these guys:
>>
>> y:/usr/src/25> grep Opt_ fs/*/super.c|wc
>>     781    2626   33703
>>
>> get handled.
>
>  while that seems to be not to complicated, I seem to have a problem passing the mount options to the kernel. They come down as mount data version "6". Apparently mount(8) or mount.nfs(8) are doing the parsing and send down the legacy data block. So, what is the minimum version of mount or mount.nfs that pass the options down unaltered?

The mount command has passed a string of options to the kernel for
particular file systems for a while, but the facility for the NFS
client to parse a string of mount options in the kernel was added only
recently -- at least 2.6.23 or 2.6.24 is required to support this.
Before this, the mount command parsed these options.

For RHEL 4, based on 2.6.9, you are stuck.  It uses a binary structure
whose fields must match between the kernel and user space.  For RH
enterprise kernels, the ABI cannot change in a given release, so RH
wouldn't take a patch to change the data structure that mount uses.
You would have to maintain such a change yourself, and build your own
kernels and mount command after each RHEL 4 update is released.

I agree that a mount option would allow more fine-grained control over
readahead.  A system wide parameter controlling readahead has always
been a weakness.  Readahead, as implemented in the VFS, has a
*per-file descriptor* context, however, which operates automatically
(and can be tuned at run-time by an application with [mf]advise(2).

As a future feature, this might work in better combination with the
per-mount bdi changes proposed by Peter to provide maximal flexibility
without exposing yet another confusing knob that could help some
workloads but hurt others.

--
Chuck Lever
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/