linux-kernel - Re: [PATCH] bnx2: Promote vector field in bnx2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20080918.164627.94070091.davem@davemloft.net>
Date:	Thu, 18 Sep 2008 16:46:27 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	benli@...adcom.com
Cc:	riel@...hat.com, mchan@...adcom.com, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bnx2: Promote vector field in bnx2_irq structure from
 u16 to unsigned int

From: "Benjamin Li" <benli@...adcom.com>
Date: Wed, 17 Sep 2008 09:04:02 -0700

> The bnx2 driver stores/uses the irq value from the pci_dev internally.
> But when it stores the irq value, it has been performing an
> integer demotion.  Because of the recent changes made to
> arch/x86/kernel/io_apic.c, the new method in creating the irq value
> (using build_irq_for_pci_dev()) has exposed this bug on x86 systems.
> 
> Because of this demotion when calling request_irq() from
> bnx2_request_irq(), the driver would get a return code of -EINVAL.
> This is because the kernel could not find the requested irq descriptor.
> By storing the irq value properly, the kernel can find the correct
> irq descriptor and the bnx2 driver can operate normally.
> 
> Signed-off-by: Benjamin Li <benli@...adcom.com>
> Signed-off-by: Michael Chan <mchan@...adcom.com>

Applied to net-2.6, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/