linux-kernel - Re: [PATCH] atmel_serial: update the powersave handler to match serial core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080919174615.26db9e8a@hskinnemo-gx745.norway.atmel.com>
Date:	Fri, 19 Sep 2008 17:46:15 +0200
From:	Haavard Skinnemoen <haavard.skinnemoen@...el.com>
To:	Michael Trimarchi <trimarchimichael@...oo.it>
Cc:	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
	Andrew Victor <linux@...im.org.za>,
	Anti Sullin <anti.sullin@...ecdesign.ee>
Subject: Re: [PATCH] atmel_serial: update the powersave handler to match
 serial core

Michael Trimarchi <trimarchimichael@...oo.it> wrote:
> > +    /* we can not wake up if we're running on slow clock */
> > +    atmel_port->may_wakeup = device_may_wakeup(&pdev->dev);
> > +    if (atmel_serial_clk_will_stop())
> > +        device_set_wakeup_enable(&pdev->dev, 0);
> > +  
> This is not true, the wakeup in the slow clock is possible, configure the
> input pin of the serial device as a gpio, and wake up on gpio. Then you
> must reconfigure as a serial pin, and you can wake up on slow clock.

Yes, but the current driver doesn't actually support that, does it?

This patch doesn't really change that assumption anyway -- it just
implements it in a way more consistent with the current serial core.

Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/