linux-kernel - Re: [PATCH] fix count(), compat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <65dd6fd50809191610o566b6747o3813255e0d6a2143@mail.gmail.com>
Date:	Fri, 19 Sep 2008 16:10:45 -0700
From:	"Ollie Wild" <aaw@...gle.com>
To:	"Peter Zijlstra" <a.p.zijlstra@...llo.nl>
Cc:	"Jason Baron" <jbaron@...hat.com>, linux-kernel@...r.kernel.org,
	"Linus Torvalds" <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] fix count(), compat_count() bounds checking

On Fri, Sep 19, 2008 at 4:06 PM, Peter Zijlstra <a.p.zijlstra@...llo.nl> wrote:
>
> On Fri, 2008-09-19 at 11:50 -0400, Jason Baron wrote:
> >
> > Simple fix seems to be chaning ++i to i++ and checking for '>='.
>
> Right - looks sane enough, although in practise I'm not sure we'll ever
> care since I suspect we'll hit the target stack limit before this.
>
> Ollie?

Sounds reasonable to me.  I'd also be ok with changing MAX_ARG_STRINGS
to 0x7FFFFFFE to help prevent people from making this mistake in the
future.

Ollie
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/