linux-kernel - Re: [PATCH -tip/master] x86: io-apic - restore_IO_APIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080919080520.GA19491@elte.hu>
Date:	Fri, 19 Sep 2008 10:05:20 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Cyrill Gorcunov <gorcunov@...il.com>
Cc:	"Maciej W. Rozycki" <macro@...ux-mips.org>,
	Yinghai Lu <yhlu.kernel@...il.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -tip/master] x86: io-apic - restore_IO_APIC_setup NULL
	pointer quick fix


* Cyrill Gorcunov <gorcunov@...il.com> wrote:

> Check if memory was granted first - we don't like NULL deref.
> It's a *quick* fix. Actually it's better to hadle this error
> at moment of memory allocation. It's save_mask_IO_APIC_setup
> route who allocates this memory (just for the record).
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@...il.com>
> ---
> 
> I'll handle this in _normal_ way tomorrow. Please review.

ok, i've applied the quick fix to tip/master - the patch will drop from 
there on the next integration run.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/