linux-kernel - Re: [PATCH] dmatest: properly handle duplicate DMA channels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080920144207.547b8ef2@hskinnemo-gx745.norway.atmel.com>
Date:	Sat, 20 Sep 2008 14:42:07 +0200
From:	Haavard Skinnemoen <haavard.skinnemoen@...el.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Timur Tabi <timur@...escale.com>, dan.j.williams@...el.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmatest: properly handle duplicate DMA channels

Andrew Morton <akpm@...ux-foundation.org> wrote:
> One of them is incorrect.  The interface is undocumented (natch), but I
> assume that GFP_KERNEL is the one to use here.

You're right -- there's no reason to use GFP_ATOMIC there. I messed
around with various kinds of locks before I realized that it was
already protected by a mutex.

Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/