linux-kernel - Re: [PATCH] dmatest: properly handle duplicate DMA channels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080920152048.75ea4655.akpm@linux-foundation.org>
Date:	Sat, 20 Sep 2008 15:20:48 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	"Dan Williams" <dan.j.williams@...el.com>
Cc:	"Timur Tabi" <timur@...escale.com>, haavard.skinnemoen@...el.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmatest: properly handle duplicate DMA channels

On Sat, 20 Sep 2008 14:40:40 -0700 "Dan Williams" <dan.j.williams@...el.com> wrote:

> When I fix this up is there a
> canonical location to document a callback interface rather than at the
> callback's typedef?

Personally I like to see at at the definition site, so that's within
the struct which contains the function pointer.  eg:

struct address_space_operations {
	int (*writepage)(struct page *page, struct writeback_control *wbc);
	int (*readpage)(struct file *, struct page *);
	void (*sync_page)(struct page *);

	/* Write back some dirty pages from this mapping. */
	int (*writepages)(struct address_space *, struct writeback_control *);

	/* Set a page dirty.  Return true if this dirtied it */
	int (*set_page_dirty)(struct page *page);

(sadly incomplete, but we tried)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/