[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <200809201756.25157.bjorn.helgaas@hp.com>
Date: Sat, 20 Sep 2008 17:56:24 -0600
From: Bjorn Helgaas <bjorn.helgaas@...com>
To: Frans Pop <elendil@...net.nl>
Cc: Rene Herman <rene.herman@...access.nl>,
linux-kernel@...r.kernel.org, Rene Herman <rene.herman@...il.com>,
Ingo Molnar <mingo@...e.hu>,
Thomas Gleixner <tglx@...utronix.de>,
Jesse Barnes <jbarnes@...tuousgeek.org>
Subject: Re: [bisected][resend] pnp: Huge number of "io resource overlap" messages
On Saturday 20 September 2008 05:49:05 pm Frans Pop wrote:
> On Thursday 18 September 2008, Bjorn Helgaas wrote:
> > On Tuesday 09 September 2008 12:31:09 pm Rene Herman wrote:
> > > On 09-09-08 19:40, Bjorn Helgaas wrote:
> > > > If the PCI device isn't fully initialized, it doesn't seem right to
> > > > check it for resource conflicts. But I don't know how to tell
> > > > that.
> > >
> > > His pci_resource_start() values are 0. How about just checking for
> > > that?
> >
> > Frans, can you test Rene's patch? I think it will solve the problem
> > you're seeing, and if so, we should put it in for 2.6.27. But I'd like
> > to have your "Tested-by" first.
>
> Tested against current git (v2.6.27-rc6-158-g9824b8f) and looks good.
> Attached the patch with Rene's Signed-off and my Tested-by for
> convenience.
>
> I had not tested earlier as you said you wanted to better understand the
> cause first. Did you get anything more about why things happen as they do
> from the info I sent?
Thanks for testing this.
We're looking at some other issues in the same area, or at least,
where the fix might be in the same area:
http://bugzilla.kernel.org/show_bug.cgi?id=10231
http://bugzilla.kernel.org/show_bug.cgi?id=9904
I am still not 100% comfortable with this because I think we really
want to know whether the BAR value is zero, not whether the CPU
address is zero, and pci_resource_start() gives us the CPU address.
Bus and CPU addresses are currently identical on x86, but I expect
that will change someday. They're already different on ia64 and
some other architectures.
Bottom line, I think we should tweak the patch to check the BAR
address before we put it in.
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists