[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080919231304.32afb437@infradead.org>
Date: Fri, 19 Sep 2008 23:13:04 -0700
From: Arjan van de Ven <arjan@...radead.org>
To: Greg KH <greg@...ah.com>
Cc: akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] debug: Introduce a dev_WARN() function
On Fri, 19 Sep 2008 21:26:30 -0700
Greg KH <greg@...ah.com> wrote:
> > in the line of dev_printk(), this patch introduces a dev_WARN()
> > macro, that takes a struct device and then a printk format/args set
> > of arguments. Unlike dev_printk(), the effect is that of WARN() in
> > that a full warning message (including filename/line, module list,
> > versions and a backtrace) is printed in addition to the device name
> > and the arguments.
>
> I like the idea, but we already have dev_warn(), so dev_WARN() might
> be a bit confusing for people.
>
> Perhaps just documenting it with a docbook tag would suffice?
I didn't think we could do kerneldoc for macros? But maybe I just
misremember
--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists