linux-kernel - Re: [1/1] w1: new driver. DS2431 chip.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 21 Sep 2008 19:53:17 +0400
From:	Evgeniy Polyakov <johnpol@....mipt.ru>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org, bernhard.weirich@...del.net
Subject: Re: [1/1] w1: new driver. DS2431 chip.

On Wed, Sep 17, 2008 at 04:00:07PM -0700, Andrew Morton (akpm@...ux-foundation.org) wrote:
> On Wed, 17 Sep 2008 19:49:29 +0400
> Evgeniy Polyakov <johnpol@....mipt.ru> wrote:
> 
> > Signed-off-by: Bernhard Weirich <bernhard.weirich@...del.net>
> > Signed-off-by: Evgeniy Polyakov <johnpol@....mipt.ru>
> 
> This was authored by Bernhard, but the way in which it was sent claims
> that it was authored by yourself.  Please add a From: line at the very
> top of the changelog body to indicate authorship.

Ok, I see. Patch was definitely created by Bernhard, I just pointed to
couple of trivial cleanups. I saw you imported it into the tree with
your fixes, thanks a lot!

> > --- linux-2.6.25.3/drivers/w1/slaves/w1_ds2431.c	1970-01-01 01:00:00.000000000 +0100
> > +++ linux-2.6.26.5/drivers/w1/slaves/w1_ds2431.c	2008-09-17 09:02:13.000000000 +0200
> > @@ -0,0 +1,318 @@
> > +/*
> > + *	w1_DS2431.c - w1 family 2d (DS2431) driver
> 
> case-insensitive filenames? ;)

Fortunately only comment :)

> > +/**
> > + * Check the file size bounds and adjusts count as needed.
> > + * This would not be needed if the file size didn't reset to 0 after a write.
> > + */
> 
> The driver has a number of comments whcih start with /**.  But that
> pattern is specifically used to flag the presence of a kerneldoc-format
> comment.  And these comments are in fact not in kerneldoc form.

I think we need to drop ** lines, since I did not convert kernel
comments into documentation, so would not be able to point to kerneldoc
(its doxygen iirc?) errors anyway.

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/