linux-kernel - Re: [patch] mm: tiny-shmem fix lor, mmap_sem vs i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13787.1222095249@redhat.com>
Date:	Mon, 22 Sep 2008 15:54:09 +0100
From:	David Howells <dhowells@...hat.com>
To:	Hugh Dickins <hugh@...itas.com>
Cc:	dhowells@...hat.com, Dave Hansen <dave@...ux.vnet.ibm.com>,
	Matt Mackall <mpm@...enic.com>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Nick Piggin <npiggin@...e.de>, a.p.zijlstra@...llo.nl,
	linux-kernel@...r.kernel.org, Dave Hansen <haveblue@...ibm.com>
Subject: Re: [patch] mm: tiny-shmem fix lor, mmap_sem vs i_mutex


Hugh Dickins <hugh@...itas.com> wrote:

> But now looking into it further, I see this is all a red herring,
> your rearrangement is not the significant difference: before that
> there was David Howells' Jan 2006 commit
> b0e15190ead07056ab0c3844a499ff35e66d27cc
> [PATCH] NOMMU: Make SYSV IPC SHM use ramfs facilities on NOMMU
> which is the one which adds do_truncate() into tiny-shmem.c's
> shmem_file_setup() but not into shmem.c's - presumably because
> config SHMEM depends on MMU so it was irrelevant in shmem.c.
>
> *That* is the relevant commit, which introduced the bad i_mutex
> within mmap_sem lock ordering, and it seems that Nick's current
> patch is wrong just to remove that do_truncate(), a significant
> change hidden inside his restoration of the original arrangement.

That would break SYSV IPC SHM under CONFIG_MMU=n conditions.

The truncate is necessary as I explained in my patch:

     (2) ramfs files now need resizing using do_truncate() rather than by
         modifying the inode size directly (see shmem_file_setup()). This
         causes ramfs to attempt to bind a block of pages of sufficient size to
         the inode.

What I didn't belabour in the patch, and perhaps I should have, is that to do
SYSV IPC SHM under NOMMU conditions, it is necessary to allocate a *contiguous*
set of pages - something that ramfs has been taught to do under NOMMU when
truncating a file upwards from zero size.  This makes POSIX SHM on ramfs files
viable also.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/