linux-kernel - Re: diet-kconfig: a script to trim unneeded kconfigs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.1.10.0809221138250.14496@gandalf.stny.rr.com>
Date:	Mon, 22 Sep 2008 11:41:36 -0400 (EDT)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	"Giacomo A. Catenazzi" <cate@...eee.net>
cc:	Takashi Iwai <tiwai@...e.de>, Chris Li <lkml@...isli.org>,
	Mauro Carvalho Chehab <mchehab@...radead.org>,
	linux-kernel@...r.kernel.org
Subject: Re: diet-kconfig: a script to trim unneeded kconfigs



On Mon, 22 Sep 2008, Giacomo A. Catenazzi wrote:
> Takashi Iwai wrote:
> > At Fri, 19 Sep 2008 16:55:51 -0700,
> > Chris Li wrote:
> > 
> > > I avoid arch/ and firmware/ because it is nasty. I figure module in
> > > arch/ is small enough I don't mind building it. And the firmware
> > > directory,
> > > if I don't build the module loads it. Those firmware will automatically
> > > skipped
> > > any way.
> > 
> > Agreed.
> > 
> > > The little tricky part is some thing like this:
> > > ========================
> > > ifeq ($(CONFIG_BLK_DEV_CMD640), m)
> > >         obj-m += cmd640.o
> > > endif
> > > ========================
> > > Internally it get convert it into:
> > > "obj-$(CONFIG_BLK_DEV_CMD640) += cmd640.o"
> 
> Are you sure?
> I.e. if you set CONFIG_BLK_DEV_CMD640=y, you see that
> the two constructs gives different results.
> 
> If the makefile author did such complex construct, I
> really think there is a reason ;-)
> 

Yes indeed, we should find out what the author meant.

 ifeq ($(CONFIG_BLK_DEV_CMD640), m)
	obj-m += cmd640.o
 endif

and

 obj-$(CONFIG_BLK_DEV_CMD640) += cmd640.o

mean two different things.

The former means to compile the cmd640 only if it is set to a module.
The later means to compile the cmd640 if it is either a module or built 
into the core kernel code.

The author needs to make this change or explain why it is like this.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/