linux-kernel - Re: [ath9k-devel] ath9k: massive unexplained latency in 2.6.27 (rc5, rc6, probably others)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43e72e890809220901y162636fu63ed133f0a0c235@mail.gmail.com>
Date:	Mon, 22 Sep 2008 09:01:48 -0700
From:	"Luis R. Rodriguez" <lrodriguez@...eros.com>
To:	"Steven Noonan" <steven@...inklabs.net>
Cc:	linux-wireless <linux-wireless@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"Senthilkumar Balasubramanian" 
	<Senthilkumar.Balasubramanian@...eros.com>,
	"ath9k-devel@...ts.ath9k.org" <ath9k-devel@...ts.ath9k.org>,
	"Luis Rodriguez" <Luis.Rodriguez@...eros.com>,
	"Johannes Berg" <johannes@...solutions.net>,
	"Ingo Molnar" <mingo@...e.hu>
Subject: Re: [ath9k-devel] ath9k: massive unexplained latency in 2.6.27 (rc5, rc6, probably others)

On Mon, Sep 22, 2008 at 8:11 AM, Steven Noonan <steven@...inklabs.net> wrote:
> On Mon, Sep 22, 2008 at 1:06 AM, Luis R. Rodriguez
> <lrodriguez@...eros.com> wrote:
>> Please test the following patch.
>>
>> diff --git a/drivers/net/wireless/ath9k/core.c b/drivers/net/wireless/ath9k/core.c
>> index c262ef2..9a51739 100644
>> --- a/drivers/net/wireless/ath9k/core.c
>> +++ b/drivers/net/wireless/ath9k/core.c
>> @@ -681,10 +681,12 @@ int ath_open(struct ath_softc *sc, struct ath9k_channel *initial_chan)
>>         * Enable MIB interrupts when there are hardware phy counters.
>>         * Note we only do this (at the moment) for station mode.
>>         */
>> +#if 0
>>        if (ath9k_hw_phycounters(ah) &&
>>            ((sc->sc_ah->ah_opmode == ATH9K_M_STA) ||
>>             (sc->sc_ah->ah_opmode == ATH9K_M_IBSS)))
>>                sc->sc_imask |= ATH9K_INT_MIB;
>> +#endif
>>        /*
>>         * Some hardware processes the TIM IE and fires an
>>         * interrupt when the TIM bit is set.  For hardware
>>
>
> It didn't apply to -rc7, but I managed to apply it manually
> (apparently you made this for wireless-testing?) and added the #if 0.
> After 7 hours uptime with the driver, no apparent interrupt storm.
>
> I'll do more thorough testing later, but I have a 3 hour drive today,
> and some packing to do, so it'll need to wait a bit.

Yeah I did it for wireless-testing. Good to hear this so far has
solved the issue. I'll port it to 27 and post it once I get your
blessings that this fixed it by a Tested-by.

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/