linux-kernel - Re: Re: [PATCH 9/13] memcg: lookup page cgroup (and remove pointer from struct page)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1222099591.16700.39.camel@lappy.programming.kicks-ass.net>
Date:	Mon, 22 Sep 2008 18:06:31 +0200
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	kamezawa.hiroyu@...fujitsu.com
Cc:	linux-mm@...ck.org, balbir@...ux.vnet.ibm.com,
	nishimura@....nes.nec.co.jp, xemul@...nvz.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: Re: [PATCH 9/13] memcg: lookup page cgroup (and remove pointer
	from struct page)

On Tue, 2008-09-23 at 01:04 +0900, kamezawa.hiroyu@...fujitsu.com wrote:
> ----- Original Message -----
> >On Mon, 2008-09-22 at 20:12 +0900, KAMEZAWA Hiroyuki wrote:
> >
> >>   - all page_cgroup struct is maintained by hash. 
> >>     I think we have 2 ways to handle sparse index in general
> >>     ...radix-tree and hash. This uses hash because radix-tree's layout is
> >>     affected by memory map's layout.
> >
> >Could you provide further detail? That is, is this solely because our
> >radix tree implementation is sucky for large indexes?
> >
> no, sparse-large index.
> 
> >If so, I did most of the work of fixing that, just need to spend a
> >little more time to stabalize the code.
> >
> 
> IIUC, radix tree's height is determined by how sparse the space is.

Right, so Yes. Its that which I fixed.

> Then, steps to reach entries is tend to be larger than hash.
> I'm sorry if I misunderstood.

No problems,. I'll try and brush up that radix tree code and post
sometime soon.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/