linux-kernel - [patch] sched: fix list traversal to use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <48D7D081.8060807@nortel.com>
Date:	Mon, 22 Sep 2008 11:06:09 -0600
From:	"Chris Friesen" <cfriesen@...tel.com>
To:	a.p.zijlstra@...llo.nl, mingo@...e.hu
CC:	Linux kernel <linux-kernel@...r.kernel.org>
Subject: [patch] sched: fix list traversal to use _rcu variant

From: Chris Friesen    <cfriesen@...tel.com>

load_balance_fair() calls rcu_read_lock() but then traverses the list
 using the regular list traversal routine.  This patch converts the
list traversal to use the _rcu version.

Signed-off-by: Chris Friesen <cfriesen@...tel.com>
Approval token "Nortel-02-July-2008-01"
Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc: Ingo Molnar <mingo@...e.hu>

---

diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c
index fb8994c..3c8f631 100644
--- a/kernel/sched_fair.c
+++ b/kernel/sched_fair.c
@@ -1507,7 +1507,7 @@ load_balance_fair(struct rq *this_rq, int this_cpu, struct rq *busiest,
 	rcu_read_lock();
 	update_h_load(busiest_cpu);
 
-	list_for_each_entry(tg, &task_groups, list) {
+	list_for_each_entry_rcu(tg, &task_groups, list) {
 		struct cfs_rq *busiest_cfs_rq = tg->cfs_rq[busiest_cpu];
 		unsigned long busiest_h_load = busiest_cfs_rq->h_load;
 		unsigned long busiest_weight = busiest_cfs_rq->load.weight;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/