linux-kernel - Re: [PATCH] mm: do_generic_file_read() doesn't need to validate filp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080922143017.F3F1.KOSAKI.MOTOHIRO@jp.fujitsu.com>
Date:	Mon, 22 Sep 2008 14:32:17 +0900
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	Krishna Kumar <krkumar2@...ibm.com>
Cc:	kosaki.motohiro@...fujitsu.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: do_generic_file_read() doesn't need to validate filp

Hi

Please write explictly that filp is never passed NULL for patch description clarify.
Otherthing, looks good to me.

Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>


> From: Krishna Kumar <krkumar2@...ibm.com>
> 
> do_generic_file_read() doesn't need to validate filp when accessing it. This
> is probably a remnant of an earlier code.
> 
> Signed-off-by: Krishna Kumar <krkumar2@...ibm.com>
> ---
>  mm/filemap.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff -ruNp 2.6.27-rc7-org/mm/filemap.c 2.6.27-rc7-new/mm/filemap.c
> --- 2.6.27-rc7-org/mm/filemap.c	2008-09-17 12:53:25.000000000 +0530
> +++ 2.6.27-rc7-new/mm/filemap.c	2008-09-17 12:53:59.000000000 +0530
> @@ -1186,8 +1186,7 @@ out:
>  	ra->prev_pos |= prev_offset;
>  
>  	*ppos = ((loff_t)index << PAGE_CACHE_SHIFT) + offset;
> -	if (filp)
> -		file_accessed(filp);
> +	file_accessed(filp);
>  }
>  
>  int file_read_actor(read_descriptor_t *desc, struct page *page,
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/