linux-kernel - Re: [Linux-fbdev-devel] [PATCH] fbdev: don't allow to set a video mode via vga= if FB doesn't support it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d9b736f0809221332q21dea0a1lb8159b64391ee978@mail.gmail.com>
Date:	Mon, 22 Sep 2008 22:32:40 +0200
From:	"Michal Januszewski" <michalj@...il.com>
To:	"Bruno Prémont" <bonbons@...ux-vserver.org>
Cc:	"Krzysztof Helt" <krzysztof.h1@...zta.fm>,
	linux-fbdev-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org,
	"Andrew Morton" <akpm@...ux-foundation.org>
Subject: Re: [Linux-fbdev-devel] [PATCH] fbdev: don't allow to set a video mode via vga= if FB doesn't support it

On Mon, Sep 22, 2008 at 22:00, Bruno Prémont <bonbons@...ux-vserver.org> wrote:

> This looks pretty much the same as what I requested some time ago:
>
> http://bugzilla.kernel.org/show_bug.cgi?id=8062
>
> Would need to check -mm archives for the actual patch.
>
> Don't remember why it did not make it to mainline...

Well, the bug and the mm fix [1] are about a similar, yet slightly different
issue than the one I'm trying to fix with my patch (note that the issue
reported in the bug is currently fixed in the kernel, but the actual fix
is differrent than the one in -mm due to x86 boot code refactoring
that took place since then).

My patch fixes the case where the framebuffer is enabled, but none of
the drivers support boot-time video mode setting, whereas the old
patch fixed the case where it was possible to set a video mode even
though the kernel didn't contain the framebuffer layer.

[1] http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc2/2.6.21-rc2-mm1/broken-out/fbdev-ignore-vesa-modes-if-framebuffer-is-disabled.patch

Best regards,
-- 
Michal Januszewski, Gentoo Linux Developer
http://people.gentoo.org/spock