linux-kernel - Re: How to kick a secondary watchdog? (Re: [PATCH 1/3] watchdog: sync linux-omap changes)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080923113210.GM5102@atomide.com>
Date:	Tue, 23 Sep 2008 14:32:16 +0300
From:	Tony Lindgren <tony@...mide.com>
To:	Wim Van Sebroeck <wim@...ana.be>
Cc:	Russell King - ARM Linux <linux@....linux.org.uk>,
	Felipe Balbi <me@...ipebalbi.com>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	"George G. Davis" <gdavis@...sta.com>, Alan Cox <alan@...hat.com>,
	Felipe Balbi <felipe.balbi@...ia.com>
Subject: Re: How to kick a secondary watchdog? (Re: [PATCH 1/3] watchdog:
	sync linux-omap changes)

* Wim Van Sebroeck <wim@...ana.be> [080923 14:20]:
> Hi Tony,
> 
> > Wim, while at it, here's a related omap_wdt question:
> > 
> > Some omap devices like Nokia 770, N800 and N810 have also a secondary
> > watchdog on the retu chip connected via cbus. This watchdog needs
> > to be kicked as it cannot be disabled.
> > 
> > We've been thinking of adding a function that omap_wdt can
> > call to also kick retu_wdt too as there is only one wdt interface.
> > 
> > Is there some better solution available?
> 
> Plan is to go to a uniform watchdog driver first, then add sysfs
> capabilities and then we can add more devices via sysfs.
> For the time being: I would kick both of them at the same time
> via the /dev/watchdog interface.

Looks like we also need to do this for the twl4030 I2C companion chip
on omap 2430 and 34xx.

So we'll do something like this for now then:

static void omap_wdt_ping(struct omap_wdt_dev *wdev)
{

...

    retu_wdt_ping(wdev);
    twl4030_wdt_ping(wdev);
    
...

}

Then have retu_wdt_ping() and twl4030_wdt_ping() functions defined as
empty static inline functions if not enabled.

Thanks Alan & Wim.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/