linux-kernel - Re: [patch] x86, ptrace: void dopiness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080923114832.GF14840@elte.hu>
Date:	Tue, 23 Sep 2008 13:48:32 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	"Metzger, Markus T" <markus.t.metzger@...el.com>
Cc:	markus.t.metzger@...il.com, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, Roland McGrath <roland@...hat.com>,
	"linux-os (Dick Johnson)" <linux-os@...logic.com>
Subject: Re: [patch] x86, ptrace: void dopiness


* Metzger, Markus T <markus.t.metzger@...el.com> wrote:

> >-----Original Message-----
> >From: Ingo Molnar [mailto:mingo@...e.hu] 
> >Sent: Montag, 22. September 2008 14:08
> >To: Metzger, Markus T
> 
> >> The void-cast is intentional in both cases.
> >> 
> >> I thought it a question of style, i.e. that we don't want void casts 
> >> just like we want NULL instead of 0.
> >
> >ok.
> >
> >But you could mark ds_release_bts() as a __must_check 
> >function, in that 
> >case the (void) has functional aspects as well: the kernel build will 
> >complain if a return value is ignored unintentionally.
> 
> Wouldn't every non-void function be __must_check?

no, only those which we mark so explicitly.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/