linux-kernel - Re: [PATCH] IDE-TAPE NULL terminate strings.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080923165914.GA7803@localhost>
Date:	Tue, 23 Sep 2008 18:59:14 +0200
From:	Mark de Wever <koraq@...all.nl>
To:	petkovbb@...il.com, Sergei Shtylyov <sshtylyov@...mvista.com>,
	Gadi Oxman <gadio@...vision.net.il>,
	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>,
	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] IDE-TAPE NULL terminate strings.

On Tue, Sep 23, 2008 at 09:48:45AM +0200, Borislav Petkov wrote:
> ---
> diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
> index 1bce84b..3833189 100644
> --- a/drivers/ide/ide-tape.c
> +++ b/drivers/ide/ide-tape.c
> @@ -2338,7 +2338,7 @@ static void idetape_get_inquiry_results(ide_drive_t *drive)
>  {
>  	idetape_tape_t *tape = drive->driver_data;
>  	struct ide_atapi_pc pc;
> -	char fw_rev[6], vendor_id[10], product_id[18];
> +	char fw_rev[4], vendor_id[8], product_id[16];
>  
>  	idetape_create_inquiry_cmd(&pc);
>  	if (idetape_queue_pc_tail(drive, &pc)) {
> @@ -2350,11 +2350,11 @@ static void idetape_get_inquiry_results(ide_drive_t *drive)
>  	memcpy(product_id, &pc.buf[16], 16);
>  	memcpy(fw_rev, &pc.buf[32], 4);
>  
> -	ide_fixstring(vendor_id, 10, 0);
> -	ide_fixstring(product_id, 18, 0);
> -	ide_fixstring(fw_rev, 6, 0);
> +	ide_fixstring(vendor_id, 8, 0);
> +	ide_fixstring(product_id, 16, 0);
> +	ide_fixstring(fw_rev, 4, 0);
>  
> -	printk(KERN_INFO "ide-tape: %s <-> %s: %s %s rev %s\n",
> +	printk(KERN_INFO "ide-tape: %s <-> %s: %.8s %.16s rev %.4s\n",
>  			drive->name, tape->name, vendor_id, product_id, fw_rev);
>  }
>  
>

I think this patch looks good, better as all previous versions
(including my initial version). I just tested it and it solves the
problem. Feel free to add my tested-by.

Regards,
Mark de Wever

PS I was not able to test earlier ;-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/