linux-kernel - Re: [PATCH] mtd: Export the ROM enable/disable helpers and use them in mtd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080923184315.13f0923f@lxorguk.ukuu.org.uk>
Date:	Tue, 23 Sep 2008 18:43:15 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Jamie Lokier <jamie@...reable.org>
Cc:	dwmw2@...radead.org, linux-mtd@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: Export the ROM enable/disable helpers and use them
 in mtd

On Tue, 23 Sep 2008 17:43:38 +0100
Jamie Lokier <jamie@...reable.org> wrote:

> Alan Cox wrote:
> >  EXPORT_SYMBOL(pci_map_rom);
> >  EXPORT_SYMBOL(pci_unmap_rom);
> > +EXPORT_SYMBOL_GPL(pci_enable_rom);
> > +EXPORT_SYMBOL_GPL(pci_disable_rom);
> 
> It doesn't _sound_ like the sort of thing tied into the kernel enough
> to deserve an EXPORT_SYMBOL_*GPL*.  Any particularly reason?

It's not my code so I can't change the licensing on it. If the original
author of that code has no objection I would also think the _GPL version
isn't needed.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/