linux-kernel - Re: [PATCH] x86: Fix 27-rc crash on vsmp due to paravirt during module load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080923180350.GB26882@localdomain>
Date:	Tue, 23 Sep 2008 11:03:50 -0700
From:	Ravikiran G Thirumalai <kiran@...lex86.org>
To:	Ingo Molnar <mingo@...e.hu>, stable@...nel.org
Cc:	linux-kernel@...r.kernel.org,
	Glauber de Oliveira Costa <glommer@...il.com>
Subject: Re: [PATCH] x86: Fix 27-rc crash on vsmp due to paravirt during
	module load

On Tue, Sep 23, 2008 at 10:31:45AM +0200, Ingo Molnar wrote:
>
>* Ravikiran G Thirumalai <kiran@...lex86.org> wrote:
>
>> 27-rc fails to boot up if configured to use modules.  Turns out 
>> vsmp_patch was marked __init, and vsmp_patch being the pvops 'patch' 
>> routine for vsmp, a call to vsmp_patch just turns out to execute a 
>> code page with series of 0xcc (POISON_FREE_INITMEM -- int3).  Since 
>> apply_paravirt can only be called during init/module load, make 
>> vsmp_patch with "__init_or_module"
>
>applied to tip/x86/urgent, thanks Ravikiran!
>


Thanks Ingo.
Can this get into 2.6.26 stable as well, please?  (Re-sending patch for -stable,
re diffed against 2.6.26.5)

Thanks,
Kiran

---

vsmp_patch has been marked with __init ever since pvops, however,
apply_paravirt can be called during module load causing calls to
freed memory location.

Since apply_paravirt can only be called during bootup and module load,
mark vsmp patch with "__init_or_module"

Signed-off-by: Ravikiran Thirumalai <kiran@...lex86.org>

Index: linux-2.6.26.5/arch/x86/kernel/vsmp_64.c
===================================================================
--- linux-2.6.26.5.orig/arch/x86/kernel/vsmp_64.c	2008-09-08 10:40:20.000000000 -0700
+++ linux-2.6.26.5/arch/x86/kernel/vsmp_64.c	2008-09-23 10:02:05.000000000 -0700
@@ -58,7 +58,7 @@
 	native_restore_fl((flags | X86_EFLAGS_IF) & (~X86_EFLAGS_AC));
 }
 
-static unsigned __init vsmp_patch(u8 type, u16 clobbers, void *ibuf,
+static unsigned __init_or_module vsmp_patch(u8 type, u16 clobbers, void *ibuf,
 				  unsigned long addr, unsigned len)
 {
 	switch (type) {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/