linux-kernel - Re: [PATCH] dm: Add support for data integrity to DM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1222195272-18674-1-git-send-email-martin.petersen@oracle.com>
Date:	Tue, 23 Sep 2008 14:41:10 -0400
From:	"Martin K. Petersen" <martin.petersen@...cle.com>
To:	agk@...rceware.org, jens.axboe@...cle.com,
	linux-kernel@...r.kernel.org, dm-devel@...hat.com
Subject: Re: [PATCH] dm: Add support for data integrity to DM

>>>>> "Andrew" == Andrew Morton <akpm@...ux-foundation.org> writes:

Sorry about the delayed response.  I'm still on the road after LPC.

Andrew> For better or for worse, the developers of dm.c have chosen to
Andrew> keep the whole file presentable in an 80-col display.  This
Andrew> patch breaks that, and they might not like this.

I've broken the lines.

[Excessive BUG_ONs]

Andrew> This will provide no more information than the oops which will
Andrew> happen two lines later.

Debugging debris.  Gone.

>> +struct request_queue *dm_queue(struct mapped_device *md)
>> +{
>> +    return md->queue;
>> +}

Andrew> This (unused, undocumented) function should be inlined.

 - It's not unused.

 - return md->queue is more descriptive than anything I could possibly
   put in a comment.

 - None of the other accessor functions in DM are inlined.  I'll let
   Alasdair decide.

Updated patches follow.

-- 
Martin K. Petersen      Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/