linux-kernel - Re: [PATCH] - Add early detection of UV system types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 23 Sep 2008 11:59:26 -0700
From:	"Yinghai Lu" <yinghai@...nel.org>
To:	"Jack Steiner" <steiner@....com>
Cc:	mingo@...e.hu, tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] - Add early detection of UV system types

On Tue, Sep 23, 2008 at 11:28 AM, Jack Steiner <steiner@....com> wrote:
> Portions of system boot needs to know if a system is a UV system prior
> to genapic initialization. This patch adds a call from acpi_boot_table_init()
> to the UV code to parse the MADT to determine if the system is a UV system.
>
> Signed-off-by: Jack Steiner <steiner@....com>
>
> ---
>  arch/x86/kernel/acpi/boot.c      |    4 ++++
>  arch/x86/kernel/genx2apic_uv_x.c |   21 ++++++++++++---------
>  arch/x86/mm/srat_64.c            |    2 +-
>  include/asm-x86/genapic_64.h     |    2 ++
>  4 files changed, 19 insertions(+), 10 deletions(-)
>
> Index: linux/arch/x86/kernel/acpi/boot.c
> ===================================================================
> --- linux.orig/arch/x86/kernel/acpi/boot.c      2008-09-23 12:55:15.000000000 -0500
> +++ linux/arch/x86/kernel/acpi/boot.c   2008-09-23 12:55:19.000000000 -0500
> @@ -1667,6 +1667,10 @@ int __init acpi_boot_table_init(void)
>
>        acpi_table_parse(ACPI_SIG_BOOT, acpi_parse_sbf);
>
> +#ifdef CONFIG_X86_64
> +       acpi_table_parse(ACPI_SIG_MADT, uv_early_madt_oem_check);
> +#endif
> +
>        /*
>         * blacklist may disable ACPI entirely
>         */

you don't need to that.

please call early_acpi_boot_init instead

sth like

diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 3d677b5..7ead2aa 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -997,6 +997,8 @@ void __init setup_arch(char **cmdline_p)
         */
        acpi_boot_table_init();

+       early_acpi_boot_init();
+
 #ifdef CONFIG_ACPI_NUMA
        /*
         * Parse SRAT to discover nodes.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/