linux-kernel - Re: [PATCH -tip/master] x86: io-apic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080923191742.GA15609@linux-os.sc.intel.com>
Date:	Tue, 23 Sep 2008 12:17:43 -0700
From:	Suresh Siddha <suresh.b.siddha@...el.com>
To:	Cyrill Gorcunov <gorcunov@...il.com>
Cc:	"Siddha, Suresh B" <suresh.b.siddha@...el.com>,
	Ingo Molnar <mingo@...e.hu>,
	LKML <linux-kernel@...r.kernel.org>,
	"Maciej W. Rozycki" <macro@...ux-mips.org>
Subject: Re: [PATCH -tip/master] x86: io-apic - interrupt remapping fix

On Tue, Sep 23, 2008 at 12:00:02PM -0700, Cyrill Gorcunov wrote:
> ---
> From: Cyrill Gorcunov <gorcunov@...il.com>
> 
> Clean up obscure for() cycle with straight while() form
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@...il.com>
> CC: Suresh Siddha <suresh.b.siddha@...el.com>
> ---
> 
> Index: linux-2.6.git/arch/x86/kernel/io_apic.c
> ===================================================================
> --- linux-2.6.git.orig/arch/x86/kernel/io_apic.c        2008-09-22 17:42:33.000000000 +0400
> +++ linux-2.6.git/arch/x86/kernel/io_apic.c     2008-09-23 22:45:58.000000000 +0400
> @@ -830,9 +830,8 @@ int save_mask_IO_APIC_setup(void)
>         return 0;
> 
>  nomem:
> -       for (; apic > 0; apic--)
> -               kfree(early_ioapic_entries[apic]);
> -       kfree(early_ioapic_entries[apic]);
> +       while (apic >= 0)
> +               kfree(early_ioapic_entries[apic--]);
>         memset(early_ioapic_entries, 0,
>                 ARRAY_SIZE(early_ioapic_entries));
> 

looks better. thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/