linux-kernel - Re: [PATCH] fsl-dma: allow Freescale Elo DMA driver to be compiled as a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e9c3a7c20809231346q264cc764s703af8b9e386e445@mail.gmail.com>
Date:	Tue, 23 Sep 2008 13:46:44 -0700
From:	"Dan Williams" <dan.j.williams@...el.com>
To:	"Timur Tabi" <timur@...escale.com>
Cc:	linux-kernel@...r.kernel.org,
	"Andrew Morton" <akpm@...ux-foundation.org>, leoli@...escale.com
Subject: Re: [PATCH] fsl-dma: allow Freescale Elo DMA driver to be compiled as a module

On Mon, Sep 22, 2008 at 1:59 PM, Timur Tabi <timur@...escale.com> wrote:
> Dan Williams wrote:
>
>> The last three hunks should be broken out into a separate 'fix' patch
>> with its own changelog.
>
> Can you be more specific?  I can see how "return 0" -> "return -ENOMEM" could be
> separated out, but the Kconfig hunk is integral to the patch, and the "if
> (fsl_chan->desc_pool) return 1;" is needed to prevent a memory leak if the
> module is unloaded.
>

Sorry, I miscounted.  I was indeed referring to the just the "return 0
--> return -ENOMEM" fix.

--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/