linux-kernel - Re: [PATCH 3/4][resubmit] TPM: rcu locking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080923150129.0d8356e8@bike.lwn.net>
Date:	Tue, 23 Sep 2008 15:01:29 -0600
From:	Jonathan Corbet <corbet@....net>
To:	Rajiv Andrade <srajiv@...ux.vnet.ibm.com>
Cc:	paulmck@...ux.vnet.ibm.com, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, serue@...ux.vnet.ibm.com,
	zohar@...ux.vnet.ibm.com, safford@...son.ibm.com,
	debora@...ux.vnet.ibm.com
Subject: Re: [PATCH 3/4][resubmit] TPM: rcu locking

On Tue, 23 Sep 2008 17:19:33 -0300
Rajiv Andrade <srajiv@...ux.vnet.ibm.com> wrote:

> Protects tpm_chip_list when transversing it.

It all looks like it should work (though it might make sense to include
<linux/rcupdate.h> and <linux/rculist.h>.  But I have to ask: do you
really need the added complexity of RCU here?  I suspect that TPM
devices don't come and go very often...once most of us have ripped it
out, we tend to leave it out...:)

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/