linux-kernel - SDHCI: timeout during data transfer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080923212459.GA13888@dreamland.darkstar.lan>
Date:	Tue, 23 Sep 2008 23:24:59 +0200
From:	Luca Tettamanti <kronos.it@...il.com>
To:	linux-kernel@...r.kernel.org
Cc:	drzeus-mmc@...eus.cx
Subject: SDHCI: timeout during data transfer

Hi,
I'm seeing timeout errors when transfering "big" (over 1MB or so) files to a SD
card (small files are ok):

[  251.956666] mmcblk0: error -110 transferring data
[  251.979810] end_request: I/O error, dev mmcblk0, sector 1572758
[  251.981477] Buffer I/O error on device mmcblk0p1, logical block 1572742
[  251.983198] lost page write due to I/O error on mmcblk0p1
[  251.983788] end_request: I/O error, dev mmcblk0, sector 1572759
[  251.983788] Buffer I/O error on device mmcblk0p1, logical block 1572743
[  251.983788] lost page write due to I/O error on mmcblk0p1
[  251.983788] end_request: I/O error, dev mmcblk0, sector 1572760
[  251.983788] Buffer I/O error on device mmcblk0p1, logical block 1572744
[  251.983788] lost page write due to I/O error on mmcblk0p1
[  251.983788] end_request: I/O error, dev mmcblk0, sector 1572761
[  251.983788] Buffer I/O error on device mmcblk0p1, logical block 1572745
[  251.983788] lost page write due to I/O error on mmcblk0p1
[  253.513336] mmcblk0: error -110 transferring data
(trashed FS here)

kernel in use is 2.6.27-rc6, and this is the controller:

09:01.1 SD Host controller: Ricoh Co Ltd R5C822 SD/SDIO/MMC/MS/MSPro Host Adapter (rev 22)
09:01.2 System peripheral: Ricoh Co Ltd R5C843 MMC Host Controller (rev 12)
09:01.3 System peripheral: Ricoh Co Ltd R5C592 Memory Stick Bus Host Adapter (rev 12)
09:01.4 System peripheral: Ricoh Co Ltd xD-Picture Card Controller (rev 12)

Googling around I found a patch[1] that introduced a quirk to address an
off-by-one issue for the timeout value in certain controllers.

With this patch:

diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index e3a8133..46899ee 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -575,7 +575,7 @@ static void sdhci_prepare_data(struct sdhci_host *host, struct mmc_data *data)
 	host->data = data;
 	host->data_early = 0;
 
-	count = sdhci_calc_timeout(host, data);
+	count = sdhci_calc_timeout(host, data) + 1;
 	writeb(count, host->ioaddr + SDHCI_TIMEOUT_CONTROL);
 
 	if (host->flags & SDHCI_USE_DMA)

I don't see timeouts anymore (just for reference, I'm not suggesting to apply it
as-is).

Luca
[1] http://www.gossamer-threads.com/lists/linux/kernel/937056
-- 
Dicono che  il cane sia  il miglior  amico dell'uomo. Secondo me  non e`
vero. Quanti dei vostri amici avete fatto castrare, recentemente?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/