linux-kernel - [PATCH] UIO: Fix mapping of logical and virtual memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080923230959.GB4066@local>
Date:	Wed, 24 Sep 2008 01:10:02 +0200
From:	"Hans J. Koch" <hjk@...utronix.de>
To:	LKML <linux-kernel@...r.kernel.org>
Cc:	Greg KH <gregkh@...e.de>, "Andrew G. Harvey" <agh@...co.com>
Subject: [PATCH] UIO: Fix mapping of logical and virtual memory

I received this code by private mail from Andrew G. Harvey who found the
bug and provided a fix for it. He also tested the patch below, we
discussed it for a while, and I believe this to be correct. I simply
took his code and made a patch from it, see below.

Thanks to Andrew for pointing this out!

Hans
---------8<----------------

From: "Andrew G. Harvey" <agh@...co.com>
To: LKML <linux-kernel@...r.kernel.org>
Cc: "Greg KH" <gregkh@...e.de>, "Hans J. Koch" <hjk@...utronix.de>
Date: Wed, 24 Sep 2008 00:43:13 +0200
Subject: UIO: Fix mapping of logical and virtual memory

mmap() doesn't work as expected for UIO_MEM_LOGICAL or UIO_MEM_VIRTUAL
mappings. The offset into the memory needs to be added, otherwise
uio_vma_fault always returns the first page only. Note that for UIO
userspace calls mmap() with offset = N * getpagesize() to access
mapping N. This must be compensated when calculating the offset. A
comment was added to explain this since it is not obvious.

Signed-off-by: "Andrew G. Harvey" <agh@...co.com>
Signed-off-by: "Hans J. Koch" <hjk@...utronix.de>
---
 drivers/uio/uio.c |   12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

Index: linux-2.6.27-rc/drivers/uio/uio.c
===================================================================
--- linux-2.6.27-rc.orig/drivers/uio/uio.c	2008-09-24 00:25:17.000000000 +0200
+++ linux-2.6.27-rc/drivers/uio/uio.c	2008-09-24 00:59:40.000000000 +0200
@@ -490,15 +490,23 @@
 {
 	struct uio_device *idev = vma->vm_private_data;
 	struct page *page;
+	unsigned long offset;

 	int mi = uio_find_mem_index(vma);
 	if (mi < 0)
 		return VM_FAULT_SIGBUS;

+	/*
+	 * We need to subtract mi because userspace uses offset = N*PAGE_SIZE
+	 * to use mem[N].
+	 */
+	offset = (vmf->pgoff - mi) << PAGE_SHIFT;
+
 	if (idev->info->mem[mi].memtype == UIO_MEM_LOGICAL)
-		page = virt_to_page(idev->info->mem[mi].addr);
+		page = virt_to_page(idev->info->mem[mi].addr + offset);
 	else
-		page = vmalloc_to_page((void*)idev->info->mem[mi].addr);
+		page = vmalloc_to_page((void *)idev->info->mem[mi].addr
+							+ offset);
 	get_page(page);
 	vmf->page = page;
 	return 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/