linux-kernel - Re: [PATCH 3/4][resubmit] TPM: rcu locking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 24 Sep 2008 10:10:41 -0300
From:	Rajiv Andrade <srajiv@...ux.vnet.ibm.com>
To:	paulmck@...ux.vnet.ibm.com
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	serue@...ux.vnet.ibm.com, zohar@...ux.vnet.ibm.com,
	safford@...son.ibm.com, debora@...ux.vnet.ibm.com
Subject: Re: [PATCH 3/4][resubmit] TPM: rcu locking

Reading the code again, we noticed that there's a put_device() missing
right inside this test:

>  	if (test_and_set_bit(0, &chip->is_open)) {
>  		dev_dbg(chip->dev, "Another process owns this TPM\n");
> -		rc = -EBUSY;
> -		goto err_out;
> +		return -EBUSY;
>  	}
> 
Since this was moved to a section before.
> -	get_device(chip->dev);
> -

I'll submit a patch to be applied on top of this one.

Rajiv Andrade
IBM Linux Technology Center
Security Development


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/