Lets use lapic_get_version helper and hide register being read. Also it allow us to make code a bit tighter. Signed-off-by: Cyrill Gorcunov --- Index: linux-2.6.git/arch/x86/kernel/apic.c =================================================================== --- linux-2.6.git.orig/arch/x86/kernel/apic.c 2008-09-24 19:17:20.000000000 +0400 +++ linux-2.6.git/arch/x86/kernel/apic.c 2008-09-24 19:33:31.000000000 +0400 @@ -309,14 +309,14 @@ int get_physical_broadcast(void) */ int lapic_get_maxlvt(void) { - unsigned int v; + unsigned int ver; - v = apic_read(APIC_LVR); + ver = lapic_get_version(); /* * - we always have APIC integrated on 64bit mode * - 82489DXs do not report # of LVT entries */ - return APIC_INTEGRATED(GET_APIC_VERSION(v)) ? GET_APIC_MAXLVT(v) : 2; + return APIC_INTEGRATED(ver) ? GET_APIC_MAXLVT(ver) : 2; } /* -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/