linux-kernel - Re: [PATCH] Create PNP device attributes via dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48DA774A.9010206@mvista.com>
Date:	Wed, 24 Sep 2008 10:22:18 -0700
From:	Drew Moseley <dmoseley@...sta.com>
To:	Kay Sievers <kay.sievers@...y.org>
Cc:	ambx1@....rr.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Create PNP device attributes via dev_attrs field of struct
 device

Kay Sievers wrote:
> 
> Any reason not to assign it statically to pnp_bus_type at in
> drivers/pnp/driver.c?
> 
> Thanks,
> Kay

Not really but since everything in the dev_attrs array is statically
defined in interface.c it was simpler to implement it this way.  To
assign it in driver.c, the array can be made non-static and an extern
added in driver.c, or the array definition can be moved to driver.c and
all the set and show functions be made non-static.  Is there a preference?

Thanks,
Drew
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/