linux-kernel - Re: [PATCH] olpc: fix endian bug in openfirmware workaround

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080924075338.GE3655@elte.hu>
Date:	Wed, 24 Sep 2008 09:53:38 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Harvey Harrison <harvey.harrison@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] olpc: fix endian bug in openfirmware workaround


* Harvey Harrison <harvey.harrison@...il.com> wrote:

> Boardrev is always treated as a u32 everywhere else, no reason to 
> byteswap the 0xc2 value.  The only use is to print out if it is a 
> prerelease board, the test being:
> 
> (olpc_platform_info.boardrev & 0xf) < 8
> 
> Which is currently always true as be32_to_cpu(0xc2) & 0xf = 0
> but I doubt that was the intention here.  The consequences of the bug
> are pretty minor though (incorrect boardrev displayed in dmesg when
> ofw support not configured)
> 
> Also annotate the temporary used to read the boardrev in the ofw
> case.
> 
> The confusion was noticed by sparse:
> arch/x86/kernel/olpc.c:206:32: warning: cast to restricted __be32
> 
> Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>

applied to tip/x86/sparse-fixes, thanks Harvey!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/