linux-kernel - Re: [PATCH 7/7] x86: print out irq nr for msi/ht -v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86802c440809251007n71738552n88b8ebfc7ecd017f@mail.gmail.com>
Date:	Thu, 25 Sep 2008 10:07:17 -0700
From:	"Yinghai Lu" <yinghai@...nel.org>
To:	"Bjorn Helgaas" <bjorn.helgaas@...com>
Cc:	"Jesse Barnes" <jbarnes@...tuousgeek.org>,
	"Len Brown" <lenb@...nel.org>, "Ingo Molnar" <mingo@...e.hu>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
	linux-acpi@...r.kernel.org
Subject: Re: [PATCH 7/7] x86: print out irq nr for msi/ht -v2

On Thu, Sep 25, 2008 at 8:00 AM, Bjorn Helgaas <bjorn.helgaas@...com> wrote:
> On Thursday 25 September 2008 12:13:43 am Yinghai Lu wrote:
>> v2: fix hpet compiling
>>
>> Signed-off-by: Yinghai Lu <yhlu.kernel@...il.com>
>> ---
>>  arch/x86/kernel/hpet.c    |    3 +++
>>  arch/x86/kernel/io_apic.c |    7 +++++++
>>  2 files changed, 10 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c
>> index 422c577..686505a 100644
>> --- a/arch/x86/kernel/hpet.c
>> +++ b/arch/x86/kernel/hpet.c
>> @@ -467,6 +467,9 @@ static int hpet_setup_irq(struct hpet_dev *dev)
>>       irq_set_affinity(dev->irq, cpumask_of_cpu(dev->cpu));
>>       enable_irq(dev->irq);
>>
>> +     printk(KERN_DEBUG "hpet: %s is using irq %#x aka %d for MSI\n",
>> +                      dev->name, dev->irq, dev->irq);
>> +
>
> Why do we want to print the irq as hex?  Do we do that anywhere else?
> I think we should pick one format and stick with it, and I think
> decimal is the logical choice because it's the most common.

when sparseirq is enabled, irq for msi will be bus_nr/dev/func + 12bits.
so show it as hex is more straight. but we can not use hex in
/proc/interrupts --ABI want decimal.

just try to print out...in log, so user could get some idea that who
is using it...

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/