linux-kernel - Re: [PATCH 2/7] acpi: remove have_arch_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <86802c440809251010r77e0aea2pfdf2e16b6441fe32@mail.gmail.com>
Date:	Thu, 25 Sep 2008 10:10:06 -0700
From:	"Yinghai Lu" <yinghai@...nel.org>
To:	"Bjorn Helgaas" <bjorn.helgaas@...com>
Cc:	"Jesse Barnes" <jbarnes@...tuousgeek.org>,
	"Len Brown" <lenb@...nel.org>, "Ingo Molnar" <mingo@...e.hu>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
	linux-acpi@...r.kernel.org
Subject: Re: [PATCH 2/7] acpi: remove have_arch_parse_srat in acpi.h

On Thu, Sep 25, 2008 at 8:01 AM, Bjorn Helgaas <bjorn.helgaas@...com> wrote:
> On Wednesday 24 September 2008 08:04:32 pm Yinghai Lu wrote:
>> 32bit don't need that anymore
>
> I don't understand the connection between this commit log and
> the patch below.
>
>> Signed-off-by: Yinghai Lu <yhlu.kernel@...il.com>
>> ---
>>  include/linux/acpi.h |    8 --------
>>  1 files changed, 0 insertions(+), 8 deletions(-)
>>
>> diff --git a/include/linux/acpi.h b/include/linux/acpi.h
>> index 4d5ec43..8eefaa9 100644
>> --- a/include/linux/acpi.h
>> +++ b/include/linux/acpi.h
>> @@ -95,18 +95,10 @@ int acpi_parse_mcfg (struct acpi_table_header *header);
>>  void acpi_table_print_madt_entry (struct acpi_subtable_header *madt);
>>
>>  /* the following four functions are architecture-dependent */
>> -#ifdef CONFIG_HAVE_ARCH_PARSE_SRAT
>> -#define NR_NODE_MEMBLKS MAX_NUMNODES
>> -#define acpi_numa_slit_init(slit) do {} while (0)
>> -#define acpi_numa_processor_affinity_init(pa) do {} while (0)
>> -#define acpi_numa_memory_affinity_init(ma) do {} while (0)
>> -#define acpi_numa_arch_fixup() do {} while (0)
>> -#else
>>  void acpi_numa_slit_init (struct acpi_table_slit *slit);
>>  void acpi_numa_processor_affinity_init (struct acpi_srat_cpu_affinity *pa);
>>  void acpi_numa_memory_affinity_init (struct acpi_srat_mem_affinity *ma);
>>  void acpi_numa_arch_fixup(void);
>> -#endif
>>
>>  #ifdef CONFIG_ACPI_HOTPLUG_CPU
>>  /* Arch dependent functions for cpu hotplug support */
>
there was some workaround for 32bit numa (srat processing),  and we
removed those workaround, and make 32bit more like 64bit.

now HAVE_ARCH_PARSE_SRAT is not defined in any place.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/