[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <48DAF40D.3040005@garzik.org>
Date: Wed, 24 Sep 2008 22:14:37 -0400
From: Jeff Garzik <jeff@...zik.org>
To: "Brandeburg, Jesse" <jesse.brandeburg@...el.com>
CC: Jeff Kirsher <jeffrey.t.kirsher@...el.com>, mingo@...e.hu,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
davem@...emloft.net, akpm@...ux-foundation.org
Subject: Re: [NET-NEXT PATCH] e1000: remove unused Kconfig option for disabling
packet split
Brandeburg, Jesse wrote:
> On Wed, 3 Sep 2008, Jeff Garzik wrote:
>>> From: Jesse Brandeburg <jesse.brandeburg@...el.com>
>>>
>>> Since the e1000/e1000e split, no hardware supported by e1000
>>> supports packet split, just remove the Kconfig option and associated
>>> code from arch/* and the driver.
>>>
>>> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
>>> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
>>> ---
>>>
>>> arch/arm/configs/iop13xx_defconfig | 1
>>> arch/arm/configs/iop32x_defconfig | 1
>> ACK, except for the defconfig changes. arch maintainers usually prefer to do
>> that themselves.
>>
>> We'd be continually patch defconfig files, if we did so every time it was
>> likely one would be updated by a Kconfig patch.
>
> Here is an updated patch without the defconfig changes
>
> == cut here ==
>
> e1000: remove Kconfig option for packet split and e1000 related code
>
> From: Jesse Brandeburg <jesse.brandeburg@...el.com>
>
> Since the e1000/e1000e split, no hardware supported by e1000
> supports packet split, just remove the Kconfig option and associated
> code from the driver.
>
> reposted without the defconfig changes, should apply to net-next
>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> ---
> drivers/net/Kconfig | 9 -
> drivers/net/e1000/e1000.h | 17 --
> drivers/net/e1000/e1000_main.c | 416 +---------------------------------------
> 3 files changed, 9 insertions(+), 433 deletions(-)
applied
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists