linux-kernel - Re: [PATCH 1/2] VMware guest detection for x86 and x86-64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080925023415.GF21049@yantp.cn.ibm.com>
Date:	Thu, 25 Sep 2008 10:34:16 +0800
From:	Yan Li <elliot.li.tech@...il.com>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Yan Li <elliot.li.tech@...il.com>,
	Alok kataria <alokkataria1@...il.com>,
	Cristi Magherusan <cristi.magherusan@....utcluj.ro>,
	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	joerg.roedel@....com, rjmaomao@...il.com,
	Yinghai Lu <yhlu.kernel@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>, nancydreaming@...il.com,
	akataria@...are.com, Zachary Amsden <zach@...are.com>,
	Daniel Hecht <dhecht@...are.com>
Subject: Re: [PATCH 1/2] VMware guest detection for x86 and x86-64

On Wed, Sep 24, 2008 at 05:26:46PM -0700, H. Peter Anvin wrote:
> Yan Li wrote:
>> My motivation behind this patch is to serve the MTRR codes to fix a
>> false warning,
>
> It's not a false warning.  It's a true warning.

You can say that warning is justified because it's true that the
MTRR's are all blank in VMware. But that warning is no good to VMware
users since it's by-design all MTRR's are blank. For example, we've
scripts watching the log for lines containing "warning" and "error" on
all production servers. So this warning actually is "false" to VMware
guest users. A KERN_INFO message should be enough here.

We already have a checking to suppress warning on KVM so I think we
should also suppress the warning for VMware guest and Virtual PC.

-- 
Li, Yan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/