linux-kernel - Re: [PATCH 3/12] memcg make root cgroup unlimited.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080926185944.c2e7055a.kamezawa.hiroyu@jp.fujitsu.com>
Date:	Fri, 26 Sep 2008 18:59:44 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	balbir@...ux.vnet.ibm.com
Cc:	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	"nishimura@....nes.nec.co.jp" <nishimura@....nes.nec.co.jp>,
	"xemul@...nvz.org" <xemul@...nvz.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Dave Hansen <haveblue@...ibm.com>, ryov@...inux.co.jp
Subject: Re: [PATCH 3/12] memcg make root cgroup unlimited.

On Fri, 26 Sep 2008 14:59:48 +0530
Balbir Singh <balbir@...ux.vnet.ibm.com> wrote:

> > I think "feature" flag is complicated, at this stage.
> > We'll add more features and not settled yet.
> > 
> 
> I know.. but breaking ABI is a bad bad thing. We'll have to keep the feature
> flags extensible (add new things). If we all feel we don't have enough users
> affected by this change, I might agree with you and make that change.
> 
Hmm...I'll drop this and add force_empty_may_fail logic in changes in force_empty.

> > Hmm, if you don't like this,
> > calling try_to_free_page() at force_empty() instead of move_account() ?
> > 
> 
> Not sure I understand this.
> 
In following series, force_empty() uses move_account() rather than forget all.
By this, accounted file caches are kept as accounted and the whole accounting
will be sane.

Another choice is calling try_to_free_pages() at force_empty rather than forget all
and makes memory usage to be Zero. This will also makes the whole accounting sange.

Thanks,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/