linux-kernel - Re: [PATCH 1/2] MN10300: Move asm-arm/cnt32_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1222426580.16700.258.camel@lappy.programming.kicks-ass.net>
Date:	Fri, 26 Sep 2008 12:56:19 +0200
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	David Howells <dhowells@...hat.com>
Cc:	torvalds@...l.org, akpm@...ux-foundation.org, nico@....org,
	linux-am33-list@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] MN10300: Move asm-arm/cnt32_to_63.h to
	include/linux/

On Wed, 2008-09-24 at 17:48 +0100, David Howells wrote:
> Move asm-arm/cnt32_to_63.h to include/linux/ so that MN10300 can make use of it
> too.
> 
> Signed-off-by: David Howells <dhowells@...hat.com>
> ---
> 
>  arch/arm/mach-pxa/time.c       |    2 +
>  arch/arm/mach-sa1100/generic.c |    2 +
>  arch/arm/mach-versatile/core.c |    2 +
>  include/linux/cnt32_to_63.h    |   80 ++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 83 insertions(+), 3 deletions(-)
>  create mode 100644 include/linux/cnt32_to_63.h

Didn't you forget to remove the old one?


> +#define cnt32_to_63(cnt_lo) \
> +({ \
> +	static volatile u32 __m_cnt_hi; \
> +	union cnt32_to_63 __x; \
> +	__x.hi = __m_cnt_hi; \
> +	__x.lo = (cnt_lo); \
> +	if (unlikely((s32)(__x.hi ^ __x.lo) < 0)) \
> +		__m_cnt_hi = __x.hi = (__x.hi ^ 0x80000000) + (__x.hi >> 31); \
> +	__x.val; \
> +})
> +
> +#endif

That code is way to smart :-)

Better make sure that non of its users are SMP capable though.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/