linux-kernel - Re: [ANNOUNCE] [PATCH] [MTD] Flex-OneNAND MTD Driver available.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9c9fda240809251731y48272a63j988e0001dc50d78@mail.gmail.com>
Date:	Fri, 26 Sep 2008 09:31:27 +0900
From:	"Kyungmin Park" <kmpark@...radead.org>
To:	apgmoorthy <moorthy.apg@...sung.com>
Cc:	linux-mtd@...ts.infradead.org,
	"Kyungmin Park" <kyungmin.park@...sung.com>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [ANNOUNCE] [PATCH] [MTD] Flex-OneNAND MTD Driver available.

Hi,

A few comments

>
> Signed-off-by: Vishak G <vishak.g@...sung.com>
> Signed-off-by: Rohit Hagargundgi <h.rohit@...sung.com>

Acked-by: Kyungmin Park <kyungmin.park@...sung.com>

> ---
> diff -uprN a/drivers/mtd/onenand/onenand_base.c
> b/drivers/mtd/onenand/onenand_base.c
> --- a/drivers/mtd/onenand/onenand_base.c        2008-09-16
> 20:48:12.000000000 +0530
> +++ b/drivers/mtd/onenand/onenand_base.c        2008-09-24
> 17:51:34.000000000 +0530
> @@ -9,6 +9,10 @@
>  *     auto-placement support, read-while load support, various fixes
>  *     Copyright (C) Nokia Corporation, 2007
>  *
> + *     Vishak G <vishak.g@...sung.com>, Rohit Hagargundgi
> <h.rohit@...sung.com>
> + *     Flex-OneNAND support
> + *     Copyright (C) Samsung Electronics, 2008
> + *
>  * This program is free software; you can redistribute it and/or modify
>  * it under the terms of the GNU General Public License version 2 as
>  * published by the Free Software Foundation.
> @@ -27,6 +31,37 @@
>
>  #include <asm/io.h>
>
> +const static int boundary[] = {
> +       FLEXONENAND_DIE0_BOUNDARY,
> +       FLEXONENAND_DIE1_BOUNDARY,
> +};
> +
> +const static int lock[] = {
> +       FLEXONENAND_DIE0_ISLOCKED,
> +       FLEXONENAND_DIE1_ISLOCKED,
> +};
> +

static const as others.


> diff -uprN a/include/mtd/mtd-abi.h b/include/mtd/mtd-abi.h
> --- a/include/mtd/mtd-abi.h     2008-09-16 20:48:12.000000000 +0530
> +++ b/include/mtd/mtd-abi.h     2008-09-24 14:09:06.000000000 +0530
> @@ -102,7 +102,11 @@ struct nand_oobinfo {
>        uint32_t useecc;
>        uint32_t eccbytes;
>        uint32_t oobfree[8][2];
> +#ifdef CONFIG_MTD_ONENAND
> +       uint32_t eccpos[128];
> +#else
>        uint32_t eccpos[32];
> +#endif
>  };
>
>  struct nand_oobfree {
> @@ -117,7 +121,11 @@ struct nand_oobfree {
>  */
>  struct nand_ecclayout {
>        uint32_t eccbytes;
> +#ifdef CONFIG_MTD_ONENAND
> +       uint32_t eccpos[128];
> +#else
>        uint32_t eccpos[64];
> +#endif
>        uint32_t oobavail;
>        struct nand_oobfree oobfree[MTD_MAX_OOBFREE_ENTRIES];
>  };
>
>

This patch is already included others. Please remove it at this patch.

Thank you,
Kyungmin Park
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/