linux-kernel - Re: [PATCH 1/7] traps: x86_64: add TRACE_IRQS_OFF in error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1222432751.13247.1276111293@webmail.messagingengine.com>
Date:	Fri, 26 Sep 2008 14:39:11 +0200
From:	"Alexander van Heukelum" <heukelum@...tmail.fm>
To:	"Ingo Molnar" <mingo@...e.hu>,
	"lkml" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/7] traps: x86_64: add TRACE_IRQS_OFF in error_entry


On Fri, 26 Sep 2008 14:03:02 +0200, "Alexander van Heukelum"
<heukelum@...tmail.fm> said:
> Add TRACE_IRQS_OFF just before entering the C code.
> 
> All exceptions are taken via interrupt gates. If irq tracing is
> enabled, it should be notified as soon as possible. Interrupts
> are only (conditionally) re-enabled in C code.
> 
> Signed-off-by: Alexander van Heukelum <fastmail.fm>

That should be: <heukelum@...tmail.fm> ---^^^
Same for patch 2/7. How did that happen?

> ---
>  arch/x86/kernel/entry_64.S |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S
> index 89434d4..78fa552 100644
> --- a/arch/x86/kernel/entry_64.S
> +++ b/arch/x86/kernel/entry_64.S
> @@ -1058,7 +1058,8 @@ KPROBE_ENTRY(error_entry)
>  	je  error_kernelspace
>  error_swapgs:	
>  	SWAPGS
> -error_sti:	
> +error_sti:
> +	TRACE_IRQS_OFF
>  	movq %rdi,RDI(%rsp) 	
>  	CFI_REL_OFFSET	rdi,RDI
>  	movq %rsp,%rdi
> -- 
> 1.5.4.3
> 
-- 
  Alexander van Heukelum
  heukelum@...tmail.fm

-- 
http://www.fastmail.fm - Or how I learned to stop worrying and
                          love email again

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/