linux-kernel - Re: [PATCH git latest] drivers/net: fixing a datarace related to update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080926222920.f251696e.komurojun-mbn@nifty.com>
Date:	Fri, 26 Sep 2008 22:29:20 +0900
From:	Komuro <komurojun-mbn@...ty.com>
To:	linux-kernel@...r.kernel.org
Cc:	tammy000@...il.com
Subject: Re: [PATCH git latest] drivers/net: fixing a datarace related to
 update_stats()

Hi,

You need two braces...

- 	if ((inw(ioaddr+EL3_STATUS) & 0xe000) == 0x2000)
+ 	if ((inw(ioaddr+EL3_STATUS) & 0xe000) == 0x2000) {
+    	    spin_lock_irqsave(&lp->lock, flags);
 	    update_stats(dev);
+    	    spin_unlock_irqrestore(&lp->lock, flags);
+	}
     }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/