lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 25 Sep 2008 20:19:18 -0700 From: Greg KH <gregkh@...e.de> To: Randy Dunlap <randy.dunlap@...cle.com> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>, linux-input@...r.kernel.org, linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org, phil@...nent.co.uk, mwilder@...nmsu.edu Subject: Re: [PATCH] Input: add mmio xi driver On Thu, Sep 25, 2008 at 06:20:55PM -0700, Randy Dunlap wrote: > On Thu, 25 Sep 2008 16:22:37 -0700 Greg KH wrote: > > > > > From: Greg Kroah-Hartman <gregkh@...e.de> > > > > This patch adds the Mimio Xi interactive whiteboard driver to the tree. > > > > It was originally written by mwilder@...nmsu.edu, but cleaned up and > > forward ported by me to the latest kernel version. > > > > > > Cc: Phil Hannent <phil@...nent.co.uk> > > Cc: <mwilder@...nmsu.edu> > > Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de> > > > > --- > > drivers/input/misc/Kconfig | 11 > > drivers/input/misc/Makefile | 1 > > drivers/input/misc/mimio.c | 913 ++++++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 925 insertions(+) > > > > --- a/drivers/input/misc/Kconfig > > +++ b/drivers/input/misc/Kconfig > > @@ -164,6 +164,17 @@ config INPUT_POWERMATE > > To compile this driver as a module, choose M here: the > > module will be called powermate. > > > > +config INPUT_MIMIO > > + tristate "Mimio Xi interactive whiteboard support" > > + depends on USB_ARCH_HAS_HCD > > + select USB > > Prefer not to select entire subsystems, but to depend on them. > However, lots of drivers in drivers/input/ select USB... :( When in Rome... :) > > +static void mimio_irq_out(struct urb *urb) > > +{ > > + unsigned long flags; > > + struct mimio *mimio; > > + > > + mimio = urb->context; > > + > > + if (urb->status) > > + dev_dbg(&mimio->idev->dev, "urb-status: %d.\n", urb->status); > > + > > + spin_lock_irqsave(&mimio->txlock, flags); > > + mimio->txflags |= MIMIO_TXDONE; > > + spin_unlock_irqrestore(&mimio->txlock, flags); > > + wmb(); > > We want comments/explanation on all barriers or just "barrier();" ?? Ick, good catch, that shouldn't be needed, I'll go delete it. > > + /* > > + * Build input device info > > + */ > > + usb_make_path(udev, path, 64); > > s/64/sizeof(path)/ Thanks, will fix. Thanks for the review, I appreciate it. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists