linux-kernel - RE: [PATCH 5/6] bfa: Brocade BFA FC SCSI driver submission (2ndtry)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C94DE2070B172459E4F1EE14BD2364E01F28079@HQ-EXCH-5.corp.brocade.com>
Date:	Thu, 25 Sep 2008 21:49:27 -0700
From:	"Jing Huang" <huangj@...cade.COM>
To:	"Greg KH" <greg@...ah.com>
Cc:	<James.Bottomley@...senPartnership.com>,
	<linux-kernel@...r.kernel.org>, <linux-scsi@...r.kernel.org>,
	"Ramkumar Vadivelu" <rvadivel@...cade.COM>,
	"Srikanth Rayas (CW)" <srayas@...cade.COM>,
	"Vinodh Ravindran" <vravindr@...cade.COM>
Subject: RE: [PATCH 5/6] bfa: Brocade BFA FC SCSI driver submission (2ndtry)

The reason we creating our own sysfs directory under /sys/devices path
was we felt the fc transport and scsi host attributes are not enough for
all the HBA management features we want to have. We have ioctl in our
non opensource driver, and we want to have something to emulate all/most
of the IOCTL functionality we have in the opensource driver. We provide
multi-level of driver/fw statistics info to the user, and we want to put
those info under a separate directory instead of throw them all under
scsi_host. I just didn't know how to create a subdirectory under scsi/fc
host. Currently, we only implement a small portion of all the IOCTL
functionalities. We want to know if this is acceptable in the upstream
kernel. 

I agree that there are a lot of redundancy with the attributes we
created under scsi_host. We will clean them up.

Jing

-----Original Message-----
From: Greg KH [mailto:greg@...ah.com] 
Sent: Thursday, September 25, 2008 7:55 PM
To: Jing Huang
Cc: James.Bottomley@...senPartnership.com; linux-kernel@...r.kernel.org;
linux-scsi@...r.kernel.org; Ramkumar Vadivelu; Srikanth Rayas (CW);
Vinodh Ravindran
Subject: Re: [PATCH 5/6] bfa: Brocade BFA FC SCSI driver submission
(2ndtry)

On Thu, Sep 25, 2008 at 06:06:00PM -0700, Jing Huang wrote:
> From: Jing Huang <huangj@...cade.com>
> 
> This patch contains document of brocade specific sysfs interface.
> It is created using 2.6.27-rc7 kernel.

What about my question for the need for all of these files and using
debugfs instead?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/