linux-kernel - Re: [patch] sched: trivial fix for incorrect comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080927182208.GA12274@elte.hu>
Date:	Sat, 27 Sep 2008 20:22:08 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc:	Chris Friesen <cfriesen@...tel.com>,
	Linux kernel <linux-kernel@...r.kernel.org>
Subject: Re: [patch] sched: trivial fix for incorrect comments


* Peter Zijlstra <a.p.zijlstra@...llo.nl> wrote:

> On Sat, 2008-09-27 at 20:10 +0200, Ingo Molnar wrote:
> > * Chris Friesen <cfriesen@...tel.com> wrote:
> > 
> > > --- a/kernel/sched.c
> > > +++ b/kernel/sched.c
> > > @@ -298,9 +298,9 @@ static DEFINE_PER_CPU(struct cfs_rq, init_cfs_rq) ____cacheline_aligned_in_smp;
> > > static DEFINE_PER_CPU(struct sched_rt_entity, init_sched_rt_entity);
> > > static DEFINE_PER_CPU(struct rt_rq, init_rt_rq) ____cacheline_aligned_in_smp;
> > > #endif /* CONFIG_RT_GROUP_SCHED */
> > > -#else /* !CONFIG_FAIR_GROUP_SCHED */
> > > +#else /* !CONFIG_USER_SCHED */
> > > #define root_task_group init_task_group
> > > -#endif /* CONFIG_FAIR_GROUP_SCHED */
> > > +#endif /* CONFIG_USER_SCHED */
> > 
> > hm, these seem to be fixed already, via:
> > 
> > | commit 9a7e0b180da21885988d47558671cf580279f9d6
> > | Author: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> > | Date:   Tue Aug 19 12:33:06 2008 +0200
> > |
> > |     sched: rt-bandwidth fixes
> > 
> > is all in tip/master.
> > 
> > (or is perhaps the direction of your patch wrong?)
> 
> No I think he got it right, as I vaguely remember fixing it too - now 
> I know where I left it ;-)
> 
> I often leave such trivial comment fixes in whatever patch I'm working 
> on at that moment.

that's OK. The risk is of course that if the other bits of this commit 
break something, and we drop or revert the commit, we drop the cleanup 
as well. But the patch was perfect in this case so all is fine :-)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/