linux-kernel - Re: [PATCH] PCIE: use PCI_EXT_CAP_NEXT to traverse PCIE extended capability list.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1222586416.25574.36.camel@ymzhang>
Date:	Sun, 28 Sep 2008 15:20:16 +0800
From:	"Zhang, Yanmin" <yanmin_zhang@...ux.intel.com>
To:	qingtao.cao@...driver.com
Cc:	linux-kernel@...r.kernel.org, yanmin.zhang@...el.com
Subject: Re: [PATCH] PCIE: use PCI_EXT_CAP_NEXT to traverse PCIE extended
	capability list.


On Sun, 2008-09-28 at 13:07 +0800, qingtao.cao@...driver.com wrote:
> PCIE extended capability unit is of 4-byte, so the least 2 bits of the most 
> significant 12 bits should be masked off to zero when accessing the extended
> capability list.
> 
> Signed-off-by: Harry Ciao<qingtao.cao@...driver.com>
Acked-by: Zhang Yanmin <yanmin_zhang@...ux.intel.com>

> ---
>  drivers/pci/pcie/aer/aerdrv_core.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/pci/pcie/aer/aerdrv_core.c
> +++ b/drivers/pci/pcie/aer/aerdrv_core.c
> @@ -52,7 +52,7 @@
>  		if (PCI_EXT_CAP_ID(reg32) == PCI_EXT_CAP_ID_ERR)
>  			break;
>  
> -		pos = reg32 >> 20;
> +		pos = PCI_EXT_CAP_NEXT(reg32);
>  	}
>  
>  	return pos;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/