linux-kernel - Re: [ath5k-devel] [PATCH 1/1] Ath5k: add AP mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 28 Sep 2008 18:14:27 +0200
From:	Jiri Slaby <jirislaby@...il.com>
To:	Gregory Nietsky <gregory@...telecom.co.za>
CC:	linville@...driver.com, linux-wireless@...r.kernel.org,
	linux-kernel@...r.kernel.org, ath5k-devel@...ema.h4ckr.net
Subject: Re: [ath5k-devel] [PATCH 1/1] Ath5k: add AP mode

On 09/28/2008 01:06 PM, Gregory Nietsky wrote:
> 
> Quick Observation  ...
> 
> it appears IEEE80211 types have been replaced with NL80211 types in
> kernel ... so would the following not be more correct and is opmode not
> defined as
> 
> struct ath5k_softc {
> ....
>        enum nl80211_iftype     opmode;
> .....

It already is.

> @@ -2130,14 +2129,15 @@ ath5k_beacon_config(struct ath5k_softc *sc)
> 
>                sc->imask |= AR5K_INT_SWBA;
> 
> -               if (ath5k_hw_hasveol(ah)) {
> -                       spin_lock(&sc->block);
> -                       ath5k_beacon_send(sc);
> -                       spin_unlock(&sc->block);
> -               }
> +               if (sc->opmode == NL80211_IFTYPE_ADHOC) {
> +                       if (ath5k_hw_hasveol(ah)) {
> +                               spin_lock(&sc->block);
> +                               ath5k_beacon_send(sc);
> +                               spin_unlock(&sc->block);
> +                       }
> +               } else
> +                       ath5k_beacon_update_timers(sc, -1);

Yeah, that's the correct hunk, thanks. I sent a non-updated version.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/