linux-kernel - Re: [PATCH]Real-time kernel compile-fix for 32-bit when disabling CONFIG_PREEMPT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7d1d9c250809290717y5824118fhdda40a9b59d65614@mail.gmail.com>
Date:	Mon, 29 Sep 2008 10:17:22 -0400
From:	"Paul Gortmaker" <paul.gortmaker@...il.com>
To:	"John Kacur" <jkacur@...il.com>
Cc:	RT <linux-rt-users@...r.kernel.org>,
	"Steven Rostedt" <rostedt@...dmis.org>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	"Ingo Molnar" <mingo@...e.hu>, LKML <linux-kernel@...r.kernel.org>,
	"Leon Woestenberg" <leon.woestenberg@...il.com>
Subject: Re: [PATCH]Real-time kernel compile-fix for 32-bit when disabling CONFIG_PREEMPT_RT

On Mon, Sep 29, 2008 at 4:10 AM, John Kacur <jkacur@...il.com> wrote:
> If you start with the real-time kernel linux-2.6.26.5-rt9 and
> configure it to disable CONFIG_PREEMPT_RT, for example
> CONFIG_PREEMPT_DESKTOP=y
> # CONFIG_PREEMPT_RT is not set
>
> you will get the following compile error on 32-bit i386. (actually,
> this will happen on any platform that doesn't use
> CONFIG_RWSEM_GENERIC_SPINLOCK)

[...]

> include/linux/rwsem.h:149: error: redefinition of 'rwsem_is_locked'
> include/asm/rwsem.h:261: error: previous definition of
> 'rwsem_is_locked' was here
> include/linux/rwsem.h: In function 'rwsem_is_locked':
> include/linux/rwsem.h:151: error: implicit declaration of function
> 'compat_rwsem_is_locked'
> make[1]: *** [arch/x86/kernel/asm-offsets.s] Error 1
> make: *** [prepare0] Error 2
>
> The fix is simple, and should be folded back into the rt-mutex-core.patch
> Fix is attached.

I saw this too, and was about to send a fix along with some other fixes
I'd stumbled across.  However, looking at the other arch implementations,
I think the fix is different from what you've posted -- i.e. I think it should
be simply this:

-static inline int rwsem_is_locked(struct compat_rw_semaphore *sem)
+static inline int compat_rwsem_is_locked(struct compat_rw_semaphore *sem)

I'll get the actual patch for this and two other compile fixes sent along
in a few minutes.

Paul.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/