linux-kernel - Re: [PATCH 01/19] pci: introduce an pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080929184519.11d08dc4@lxorguk.ukuu.org.uk>
Date:	Mon, 29 Sep 2008 18:45:19 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Jesse Barnes <jbarnes@...tuousgeek.org>
Cc:	Rolf Eike Beer <eike-kernel@...tec.de>,
	Arjan van de Ven <arjan@...radead.org>,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH 01/19] pci: introduce an pci_ioremap(pdev, barnr)
 function

> > This is the same like pci_iomap(pdev, number, 0), no?
> 
> Yeah... Looks like that function isn't that widely used though.  Is the maxlen 
> param really needed?  Looks like the drivers that use it often pass 0 or the 

In some cases yes you do need the length.

> BAR length anyway, and Arjan converted existing drivers too, which is where 
> the real work is.

He could have converted them to the existing perfectly good API not
invented another one. He still can - I'm sure its a perl one liner to
redo them in terms of pci_iomap()

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/