linux-kernel - Re: [PATCH 01/19] pci: introduce an pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200809291126.42753.jbarnes@virtuousgeek.org>
Date:	Mon, 29 Sep 2008 11:26:41 -0700
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Arjan van de Ven <arjan@...radead.org>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Rolf Eike Beer <eike-kernel@...tec.de>,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH 01/19] pci: introduce an pci_ioremap(pdev, barnr) function

On Monday, September 29, 2008 11:15 am Arjan van de Ven wrote:
> On Mon, 29 Sep 2008 18:45:19 +0100
>
> Alan Cox <alan@...rguk.ukuu.org.uk> wrote:
> > > > This is the same like pci_iomap(pdev, number, 0), no?
> > >
> > > Yeah... Looks like that function isn't that widely used though.  Is
> > > the maxlen param really needed?  Looks like the drivers that use it
> > > often pass 0 or the
> >
> > In some cases yes you do need the length.
>
> so we should have a 2nd api for those "some cases", that's ok.

Right, I'm definitely not suggesting that we don't provide a way to provide 
length, but if 90+% of callers don't need it, we should probably have a 
simpler API that does the bare minimum.

Jesse
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/